It's been two years since Microsoft unveiled a light theme for Windows, and Apple's macOS has had a light theme since - well, forever - so it was only a matter of time before Google decided to adopt a light theme too. The tablet mode shelf also adapts to the new light theme, as mentioned in this commit. Still not convinced? Another commit completely overhauls the launcher colors to adapt to the light theme, like the app drawer background, search box, suggestion bubbles underneath the search box, and expand arrow. It's different from the current builds of Chrome OS, which specifies SK_ColorBLACK in login_constants.h instead.
CHROME OS DARK MODE CODE
The code says that when the light theme is switched on, Chrome OS will use white as its base if it can't find a way to tint the lockscreen using a color from your wallpaper. If we examine line 116 of Skia's SK_Color's header file, this reveals what SK_ColorWHITE is:Ĭonstexpr SkColor SK_ColorWHITE = SkColorSetARGB(0xFF, 0xFF, 0xFF, 0xFF) The light mode base color of the login/lock screen when the color extractedĬonstexpr SkColor kLightModeBaseColor = SK_ColorWHITE įor reference, SK_Color is a function computed by Skia a graphics library used to render graphics and text on Chrome and Chrome OS. If you dig a bit deeper into the code, you'll reveal an interesting change in login_constants.h: The recently merged commit talks about a light theme for the login screen and updates a few buttons to match the theme. Last night, I discovered several commits in the Chromium Gerrit that point to a brand new light theme coming to Chrome OS. I think the developers at Google realize that having this inconsistent look is not the right play, so they decided to do something about it. But there's also some random splashes of dark theme elements in Chrome OS, like on the system tray and the Chrome OS launcher. Technically, Chrome OS is already using a "light" theme, like its file manager and the settings page. You might be asking yourself, "wait, I thought Chrome OS was already using a light theme?" Well, sort of. I'll admit - I was unsure if this suggested we were getting a dark theme soon, but I knew it was coming thanks to several code changes discovered by Chrome Story. I did not expect Google also to be working on a light theme. I bring this up because while I was writing that article, I noticed that some of the wallpapers in the Elements collection have light and dark variants. I don't see any change really since M88 or so.A few days ago, I covered the new wallpaper collections that Google published on the Chrome OS Canary channel. It also still doesn't render some basic UI elements in any kind of dark mode, like title bars on certain pages/PWAs. But trying to "smartly" re-render pages in a forced dark mode that weren't designed for it, is just a bad idea (at least if it's not optional). I'd still probably want separate options. If it just enables sending a hint to the website on which theme to use (which is one of the things enabling the flag does), that'd be ok maybe. They REALLY need to decouple those things. Which still really breaks a bunch of sites. Some sites it was nice, but I don't want that option just to enable OS UI elements in dark mode.Įdit: Just checked in M90 beta latest anyway - it still requires "Force Dark Mode for Web Contents" for any of the rest of the "dark mode" options to be active. Which REALLY broke a bunch of sites, and on a slew of others just kinda didn't work well.
try to modify various websites before displaying. My big problem before (haven't tried in m90) was that enabling dark mode also requieed enabling "render websites in dark mode", I.e. I'm not seeing it, what's different there versus 90 or 89 or 88? Guide: Interactive Chromebook Comparison & Buyer's Guide Chart
CHROME OS DARK MODE ANDROID
List of Chrome OS Systems Supporting Android Apps Would you like to be verified as an employee? Contact us via modmail. Please note that these individuals represent their own opinions, not Google's, when participating in the sub, unless they explicitly state they're representing Google They can be identified by the "Verified Googler" user flair. You may see a Google employee occasionally comment on the subreddit. Join our Discord server! Google Employees As a lightweight OS designed primarily for web-based and app-based computing, it is fast, secure, and resilient to viruses and malware. Chrome OS is Google's Linux-based operating system built around the Chrome web browser that can run Android apps.
0 kommentar(er)
